fix: add iteration limit to SPV fee calculation loop#620
fix: add iteration limit to SPV fee calculation loop#620lklimek merged 1 commit intodashpay:v1.0-devfrom
Conversation
Replace unbounded loop with a capped for loop (max 50 iterations) in the SPV fee calculation to prevent potential infinite loops when the scale factor converges but never meets the exit condition. Cherry-picked from ralph/improvements (commit 557acb2).
|
Warning Rate limit exceeded
⌛ How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. 🚦 How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. Our paid plans have higher rate limits than the trial, open-source and free plans. In all cases, we re-allow further reviews after a brief timeout. Please see our FAQ for further information. 📒 Files selected for processing (1)
✨ Finishing Touches🧪 Generate unit tests (beta)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
|
@coderabbitai review |
✅ Actions performedReview triggered.
|
3 participants
Replace unbounded
loopwith a cappedforloop (max 50 iterations) in the SPV fee calculation to prevent potential infinite loops.Problem
The fee estimation loop in
build_transaction_for_spv_walletuses an unboundedloopthat adjusts a scale factor to find a valid transaction. If the scale factor converges without meeting either exit condition (successful build orInsufficientFundswith no progress), the loop runs forever.Fix
Cap the loop at 50 iterations and return a clear error if no valid transaction is found within that budget. 50 iterations is generous — in practice, convergence happens within 2-3 iterations.
Cherry-picked from
ralph/improvements(commit 557acb2).Validation
What was tested:
cargo clippy --all-features --all-targets -- -D warnings— lint checkcargo test --all-features --workspace— full workspace test suiteResults:
ClippyCI check — pass (5m27s)Test SuiteCI check — pass (7m1s)Environment: Local macOS arm64; GitHub Actions CI (ubuntu-latest)